Avoid upgrading template if no hostProps, for better perf. #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
sorvell
suggested changes
Apr 10, 2019
| @@ -364,7 +364,7 @@ function createTemplatizerClass(template, templateInfo, options) { | |||
| */ | |||
| function addPropagateEffects(template, templateInfo, options) { | |||
| let userForwardHostProp = options.forwardHostProp; | |||
| if (userForwardHostProp) { | |||
| if (userForwardHostProp && templateInfo.hasHostProps) { | |||
There was a problem hiding this comment.
Let's add a comment here or perhaps just in the doc for the function explaining what this does so it's clear why it's only related to hostProps.
sorvell
approved these changes
Apr 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When e.g. a
dom-repeatonly binds to local instance properties (likeitemorindex), it is unnecessary to "upgrade" the associated<template>as a PropertyEffects client, since there will be no host properties to forward to it. This condition can be detected based on the count of host properties in the template.